fix: Make sure the package can be built on Flutter web #990
Conversation
|
Will create a PR for publishing a new version right after this PR is merged. Once we publish a new yet_another_json_isolate with this update, the currently retracted functions_client v2.3.0 will be restored. |
| @@ -21,3 +21,21 @@ dev_dependencies: | |||
|
|
|||
| flutter: | |||
| uses-material-design: true | |||
| melos_managed_dependency_overrides: functions_client,gotrue,postgrest,realtime_client,storage_client,yet_another_json_isolate | |||
There was a problem hiding this comment.
I'm unsure about these changes here. Did you run any command to produce these lines? Is there no way to include the example in the bootstrap to avoid modifying the overrides in the pubspec.yaml?
There was a problem hiding this comment.
What is the concern? For now, this solves our issue, ensuring that the package works on Flutter web. I can see that this can cause slight inconvenience for anyone viewing the example directly, but that's not the top priority issue that we have right now, and we can take our time to figure out if there is a better way of overriding the dependencies.
There was a problem hiding this comment.
Okay, I have updated the melos config instead of the pubspec.yaml file of the example.
There was a problem hiding this comment.
And of course now the tests are failing 😂
There was a problem hiding this comment.
I wouldn't add the packages to the bootstrap section. Just the oneline under packages
There was a problem hiding this comment.
The CI is probably failing, because pub get for the example app is running before some of the other packages. I have to run now for a bit, but will take a look when I come back.
There was a problem hiding this comment.
The issue was, that melso tried to use the flutter cli, because the example is a flutter package and was not excluded like the supabase_flutter package everywhere manually.
|
Nice! Thanks for the fix @Vinzent03 ! |
What kind of change does this PR introduce?
Fixes an issue where the package is not able to build on Flutter web
Closes #989